Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a go module for CRDs #1565

Merged
merged 15 commits into from
Jan 9, 2025
Merged

Create a go module for CRDs #1565

merged 15 commits into from
Jan 9, 2025

Conversation

swang392
Copy link
Contributor

@swang392 swang392 commented Dec 13, 2024

What does this PR do?

Create a go module for CRDs

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

  • run go work sync to update dependencies
  • verify that everything builds and tests as normal

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@swang392 swang392 added the enhancement New feature or request label Dec 13, 2024
@swang392 swang392 added this to the v1.12.0 milestone Dec 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.51%. Comparing base (0ca2c91) to head (879fff5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1565      +/-   ##
==========================================
+ Coverage   48.94%   49.51%   +0.57%     
==========================================
  Files         227      210      -17     
  Lines       20636    20184     -452     
==========================================
- Hits        10101     9995     -106     
+ Misses      10010     9665     -345     
+ Partials      525      524       -1     
Flag Coverage Δ
unittests 49.51% <ø> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ca2c91...879fff5. Read the comment docs.

api/go.mod Outdated
github.com/spf13/pflag v1.0.5 // indirect
github.com/x448/float16 v0.8.4 // indirect
golang.org/x/exp v0.0.0-20240909161429-701f63a606c0 // indirect
golang.org/x/net v0.29.0 // indirect

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Library Vulnerability

golang.org/x/net → 0.29.0

Suggested change
golang.org/x/net v0.29.0 // indirect
golang.org/x/net vv0.33.0// indirect
Non-linear parsing of case-insensitive content in golang.org/x/net/html (...read more)

An attacker can craft an input to the Parse functions that would be processed non-linearly with respect to its length, resulting in extremely slow parsing. This could cause a denial of service.

View in Datadog  Leave us feedback  Documentation

@swang392 swang392 marked this pull request as ready for review January 6, 2025 21:55
@swang392 swang392 requested a review from a team as a code owner January 6, 2025 21:55
@swang392 swang392 modified the milestones: v1.12.0, v1.13.0 Jan 6, 2025
@swang392 swang392 merged commit a3e7eab into main Jan 9, 2025
19 checks passed
@swang392 swang392 deleted the swang392/crd branch January 9, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants